Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit empty channels with channel copier tool #61

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Permit empty channels with channel copier tool #61

merged 2 commits into from
Jul 3, 2024

Conversation

SwissalpS
Copy link
Contributor

It's been so annoying not being able to set or read empty channels.

@SwissalpS SwissalpS added the enhancement New feature or request label Jun 29, 2024
@SwissalpS SwissalpS marked this pull request as ready for review June 29, 2024 12:08
@SwissalpS
Copy link
Contributor Author

I wish this mod wasn't written in such a hasty way with endless lines.
Fixing all of that is out of the scope of this PR though.

wsor4035
wsor4035 approved these changes Jun 30, 2024
View reviewed changes
Copy link

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit, didnt test

@OgelGames
Copy link
Contributor

Yeah, yet another candidate for a rewrite... This will do for now 👍

@OgelGames OgelGames merged commit 4b4dc62 into master Jul 3, 2024
4 checks passed
@OgelGames OgelGames deleted the permitMTchannelsWithChannelCopier branch July 3, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsor4035 wsor4035 wsor4035 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwissalpS @OgelGames @wsor4035